Re: [PATCH RFC v1 06/11] x86/fpu/mpx: Remove MPX xstate component support
From: Ingo Molnar
Date: Thu Feb 27 2025 - 14:15:49 EST
* Chang S. Bae <chang.seok.bae@xxxxxxxxx> wrote:
> A new xstate component is set to occupy the position previously used by
> MPX in the non-compacted format, then creating a fundamental conflict
> between the two.
>
> Currently, xfeature_noncompact_order[] includes MPX, but the introduction
> of the new feature would cause a direct conflict there unless MPX is
> removed. Fortunately, MPX support has already been deprecated and
> effectively removed by commit:
>
> 45fc24e89b7c ("x86/mpx: remove MPX from arch/x86")
>
> Explicitly disable the deprecated feature to reserve a space for the new
> xstate.
>
> Signed-off-by: Chang S. Bae <chang.seok.bae@xxxxxxxxx>
> ---
> Several code references to this feature macro remain, primarily on the
> KVM side. While they are likely to become obsolete after this patch,
> their cleanup has been deferred at this review stage: This can be
> addressed in a follow-up patch or included as an optional part of APX
> enablement, I suppose.
So can this patch be moved further up in the series (without breaking
anything), to make it easier to review the impact of the APX changes?
Thanks,
Ingo