Re: [PATCH 2/7] x86, lib: Drop the unused return value from wbinvd_on_all_cpus()
From: Sean Christopherson
Date: Thu Feb 27 2025 - 14:59:21 EST
On Wed, Feb 26, 2025, Sean Christopherson wrote:
> Drop wbinvd_on_all_cpus()'s return value; both the "real" version and the
> stub always return '0', and none of the callers check the return.
Drat. None of the callers _in my working tree_. I only checked a sparse working
tree and missed that the DRM code checks the return value. Luckily, it's uninteresting
code (and dead to boot). I'll add a patch to drop the checks on the return value.
drivers/gpu/drm/drm_cache.c: if (wbinvd_on_all_cpus())
drivers/gpu/drm/drm_cache.c- pr_err("Timed out waiting for cache flush\n");
--
drivers/gpu/drm/drm_cache.c: if (wbinvd_on_all_cpus())
drivers/gpu/drm/drm_cache.c- pr_err("Timed out waiting for cache flush\n");
--
drivers/gpu/drm/drm_cache.c: if (wbinvd_on_all_cpus())
drivers/gpu/drm/drm_cache.c- pr_err("Timed out waiting for cache flush\n");