Re: [PATCH v2 1/2] ARM: substitute OVERLAY description in linker script

From: Linus Walleij
Date: Thu Feb 27 2025 - 18:22:58 EST


On Mon, Feb 24, 2025 at 1:54 PM Christian Eggers <ceggers@xxxxxxx> wrote:

> If linker garbage collection is active, we must ensure that the vectors
> are not removed during linking (by using the KEEP keyword). But it
> seems that the LLD linker doesn't support using the KEEP() keyword
> within an overlay description.
>
> The GNU linker manual shows an alternative way to accomplish the same
> result without using the overlay statement:
>
> https://sourceware.org/binutils/docs/ld/Overlay-Description.html
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202502222158.UhwuvDZv-lkp@xxxxxxxxx/
> Signed-off-by: Christian Eggers <ceggers@xxxxxxx>

Looks right to me:
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij