Re: [RFC PATCH 0/3] gpu: nova-core: add basic timer subdevice implementation
From: Dave Airlie
Date: Thu Feb 27 2025 - 21:25:29 EST
On Fri, 28 Feb 2025 at 11:49, Timur Tabi <ttabi@xxxxxxxxxx> wrote:
>
> On Fri, 2025-02-28 at 07:37 +1000, Dave Airlie wrote:
> > I've tried to retrofit checking 0xffffffff to drivers a lot, I'd
> > prefer not to. Drivers getting stuck in wait for clear bits for ever.
>
> That's what read_poll_timeout() is for. I'm surprised Nouveau doesn't use it.
That doesn't handle the PCIE returns 0xffffffff case at all, which is
the thing we most want to handle, it also uses the CPU timer whereas
nouveau's wait infrastructure uses the GPU timer usually (though that
could be changed).
Dave.