Re: [PATCH sched_ext/for-6.15 v3 3/5] sched_ext: Add scx_kfunc_ids_ops_context_sensitive for unified filtering of context-sensitive SCX kfuncs
From: Alexei Starovoitov
Date: Thu Feb 27 2025 - 21:38:55 EST
On Thu, Feb 27, 2025 at 1:23 PM Juntong Deng <juntong.deng@xxxxxxxxxxx> wrote:
>
> >> +static int scx_kfunc_ids_ops_context_sensitive_filter(const struct bpf_prog *prog, u32 kfunc_id)
> >> +{
> >> + u32 moff, flags;
> >> +
> >> + if (!btf_id_set8_contains(&scx_kfunc_ids_ops_context_sensitive, kfunc_id))
> >> + return 0;
> >> +
> >> + if (prog->type == BPF_PROG_TYPE_SYSCALL &&
> >> + btf_id_set8_contains(&scx_kfunc_ids_unlocked, kfunc_id))
> >> + return 0;
> >
> > Not from this change but these can probably be allowed from TRACING too.
> >
>
> Not sure if it is safe to make these kfuncs available in TRACING.
> If Alexei sees this email, could you please leave a comment?
Hold on, you want to enable all of scx_kfunc_ids_unlocked[] set
to all of TRACING ? What is the use case ?
Maybe it's safe, but without in-depth analysis we shouldn't.
Currently sched-ext allows scx_kfunc_set_any[] for tracing.
I would stick to that in this patch set.