Re: [PATCH v4 1/2] dt-bindings: media: cdns,csi2rx.yaml: Add optional interrupts for cdns-csi2rx

[Jai Luthra]

Hi Krzysztof,

On Fri, Feb 28, 2025 at 08:34:22AM +0100, Krzysztof Kozlowski wrote:
> On Thu, Feb 27, 2025 at 01:59:19PM +0530, Yemike Abhilash Chandra wrote:
> > diff --git a/Documentation/devicetree/bindings/media/cdns,csi2rx.yaml b/Documentation/devicetree/bindings/media/cdns,csi2rx.yaml
> > index 2008a47c0580..054ed4b94312 100644
> > --- a/Documentation/devicetree/bindings/media/cdns,csi2rx.yaml
> > +++ b/Documentation/devicetree/bindings/media/cdns,csi2rx.yaml
> > @@ -24,6 +24,16 @@ properties:
> >    reg:
> >      maxItems: 1
> >  
> > +  interrupts:
> > +    minItems: 1
> > +    maxItems: 2
> > +
> > +  interrupt-names:
> > +    minItems: 1
> > +    items:
> > +      - const: error_irq
> > +      - const: irq
> 
> And how is this second interrupt in existing integrations?
> 

TI SoCs integrate both of these if I understood the TRM correctly.

Not sure about StarFive, maybe Changhuang can confirm that both irq and 
error_irq are integrated.

> This is supposed to be constrained per variant... which probably will
> tell you that these are not optional now.
> 

To make sure I understand, we mark them both as non-optional in the bindings 
by default. And if some particular SoC chooses to not integrate the second irq 
they may add a constraint based on compatible?

That seems perfectly reasonable. With that change,

Reviewed-by: Jai Luthra <jai.luthra@xxxxxxxxx>

> Best regards,
> Krzysztof
>

Attachment: signature.asc
Description: PGP signature