Re: [PATCH] gpiolib: remove unneeded WARN_ON() from gpiochip_set_multiple()

From: Linus Walleij
Date: Fri Feb 28 2025 - 03:30:23 EST


On Thu, Feb 27, 2025 at 4:28 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:

> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>
> GPIO drivers are not required to support set_multiple() - the core will
> fallback to calling set() for each line if it's missing. Remove the
> offending check from gpiochip_set_multiple().
>
> Fixes: 98ce1eb1fd87 ("gpiolib: introduce gpio_chip setters that return values")
> Reported-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> Closes: https://lore.kernel.org/all/ab3e42c0-70fa-48e0-ac93-ecbffef63507@xxxxxxxxxxx/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>

That's right.
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij