Re: [PATCH v2 05/16] elf, uapi: Add type ElfXX_Versym

From: Vincenzo Frascino
Date: Fri Feb 28 2025 - 07:24:54 EST




On 26/02/2025 11:44, Thomas Weißschuh wrote:
> The types are used by tools/testing/selftests/vDSO/parse_vdso.c.
> To be able to build the vDSO selftests without a libc dependency,
> add the types to the kernels own UAPI headers.
>
> As documented by elf(5).
>
> Reviewed-by: Kees Cook <kees@xxxxxxxxxx>
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@xxxxxxxxxxxxx>
> ---
> include/uapi/linux/elf.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/uapi/linux/elf.h b/include/uapi/linux/elf.h
> index d040f12ff1c0ae3dde5c371c81d6089118fbe8ed..8846fe03ca5b836c96aad1be6d8fb9daf3d4b1d9 100644
> --- a/include/uapi/linux/elf.h
> +++ b/include/uapi/linux/elf.h
> @@ -11,6 +11,7 @@ typedef __u16 Elf32_Half;
> typedef __u32 Elf32_Off;
> typedef __s32 Elf32_Sword;
> typedef __u32 Elf32_Word;
> +typedef __u16 Elf32_Versym;
>
> /* 64-bit ELF base types. */
> typedef __u64 Elf64_Addr;
> @@ -21,6 +22,7 @@ typedef __s32 Elf64_Sword;
> typedef __u32 Elf64_Word;
> typedef __u64 Elf64_Xword;
> typedef __s64 Elf64_Sxword;
> +typedef __u16 Elf64_Versym;
>
> /* These constants are for the segment types stored in the image headers */
> #define PT_NULL 0
>

Reviewed-by: Vincenzo Frascino <vincenzo.frascino@xxxxxxx>

--
Regards,
Vincenzo