Re: [GIT PULL] afs, rxrpc: Clean up refcounting on afs_cell and afs_server records

[David Howells]

Jakub Kicinski <kuba@xxxxxxxxxx> wrote:

> fs/afs/cell.c:203:5-22: WARNING: Unsigned expression compared with zero: cell -> dynroot_ino < 0

I'll make this change:

--- a/fs/afs/cell.c
+++ b/fs/afs/cell.c
@@ -200,7 +200,7 @@ static struct afs_cell *afs_alloc_cell(struct afs_net *net,
        atomic_inc(&net->cells_outstanding);
        cell->dynroot_ino = idr_alloc_cyclic(&net->cells_dyn_ino, cell,
                                             2, INT_MAX / 2, GFP_KERNEL);
-       if (cell->dynroot_ino < 0)
+       if ((int)cell->dynroot_ino < 0)
                goto error;
        cell->debug_id = atomic_inc_return(&cell_debug_id);
 

to patch 2 ("afs: Change dynroot to create contents on demand").

I'm not sure why gcc didn't warn about this - I'm sure it used to.

David