Re: [PATCH net-next v3 09/13] net: phylink: Use phy_caps_lookup for fixed-link configuration

From: Russell King (Oracle)
Date: Fri Feb 28 2025 - 11:21:19 EST


On Fri, Feb 28, 2025 at 03:55:34PM +0100, Maxime Chevallier wrote:
> adv = pl->link_config.advertising;
> linkmode_zero(adv);
> - linkmode_set_bit(s->bit, adv);
> + linkmode_and(adv, pl->supported, c->linkmodes);

There is no need for linkmode_zero() with linkmode_and() immediately
after. linkmode_and() writes to its entire destination.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!