Re: [PATCH v2] sched_ext: Add trace point to track sched_ext core events
From: Tejun Heo
Date: Fri Feb 28 2025 - 12:31:56 EST
On Fri, Feb 28, 2025 at 11:03:54AM +0100, Andrea Righi wrote:
> > +TRACE_EVENT(sched_ext_event,
> > + TP_PROTO(const char *name, __u64 delta),
> > + TP_ARGS(name, delta),
> > +
> > + TP_STRUCT__entry(
> > + __string(name, name)
> > + __field( __u64, delta )
>
> I'm wondering if we should use a __s64 here (and %lld below). We don't have
> negative deltas right now, but in the future who knows...
>
> Apart than that, everything else looks good to me.
And let's also print out the updated value.
Thanks.
--
tejun