Re: [PATCH v2] rust: adding UniqueRefCounted and UniqueRef types

[Boqun Feng]

On Fri, Feb 28, 2025 at 06:22:58PM +0000, Oliver Mangold wrote:
> On 250228 1009, Boqun Feng wrote:
> > 
> > Please add the "# Examples" section as I requested:
> > 
> > 	https://lore.kernel.org/rust-for-linux/Z8HcHVtPiG-X6ujP@xxxxxxxx/
> > 
> > I also would like to know why do you think it's OK to ignore my previous
> > comment, thanks!
> > 
> 
> I intend to. Don't worry. I totally have it in mind that, this is missing.
> As said, I will do it in a couple of days. Sorry if the update
> caused confusion.
> 

I should appologize as well, after re-reading the email exchange between
us, I realized I wasn't clear about whether my request was including the
tests with the patch or not. So it's reasonable you thought a separate
patch would work.

Now as we cleared things, I want to make sure that it's clear that I
would like to see the patch with examples in it. 

> I am aware this won't be the final version, but I thought
> I still post this one correctly formatted, as Miguel requested.
> 

Yes, I figured that's what you planned to do, although it's better if
you could provide some information between versions, one example would
be:

	https://lore.kernel.org/rust-for-linux/20250227193522.198344-1-lyude@xxxxxxxxxx/

i.e. you can add some description after the "---" line, and that won't
affect git to apply the patches. Usually people put changes between
versions, and in this case since you just want to update a version that
is not the final version, you can add some description about that there
as well.

> I assure you, I'm not ignoring your comment and request at all.
> 

Thanks! Again, sorry for not being clear in previous emails.

Regards,
Boqun

> Oliver
>