Re: [PATCH v2] rust: adding UniqueRefCounted and UniqueRef types
From: Oliver Mangold
Date: Fri Feb 28 2025 - 13:42:42 EST
On 250228 1929, Andreas Hindborg wrote:
>
> I would suggest splitting out the use case from the commit message:
>
Yes, that makes sense. Will do.
>
> The comments after the --- will not got in the commit log, they are a
> message for the review process only.
>
Ahhh. Honestly I'm not very familiar with the format-patch/am
method, yet. That was a gap in my understanding.
Thanks for pointing that out. Now everything makes sense.
On 250228 1033, Boqun Feng wrote:
>
> Now as we cleared things, I want to make sure that it's clear that I
> would like to see the patch with examples in it.
>
That's fine. That's a reasonable request. Will do.
>
> i.e. you can add some description after the "---" line, and that won't
> affect git to apply the patches. Usually people put changes between
> versions, and in this case since you just want to update a version that
> is not the final version, you can add some description about that there
> as well.
>
Yes. I just learned that it's working like this. See above :)
>
> Thanks! Again, sorry for not being clear in previous emails.
>
Don't worry.
Best,
Oliver