Re: [PATCH net-next] net: filter: Avoid shadowing variable in bpf_convert_ctx_access()

From: Yonghong Song
Date: Fri Feb 28 2025 - 13:55:42 EST




On 2/28/25 10:43 AM, Breno Leitao wrote:
Rename the local variable 'off' to 'offset' to avoid shadowing the existing
'off' variable that is declared as an `int` in the outer scope of
bpf_convert_ctx_access().

This fixes a compiler warning:

net/core/filter.c:9679:8: warning: declaration shadows a local variable [-Wshadow]

Signed-off-by: Breno Leitao <leitao@xxxxxxxxxx>

Make sense to me.

Acked-by: Yonghong Song <yonghong.song@xxxxxxxxx>