Re: [PATCH v14 06/13] x86/mm: use broadcast TLB flushing for page reclaim TLB flushing
From: Borislav Petkov
Date: Fri Feb 28 2025 - 13:58:00 EST
On Tue, Feb 25, 2025 at 10:00:41PM -0500, Rik van Riel wrote:
> In the page reclaim code, we only track the CPU(s) where the TLB needs
> to be flushed, rather than all the individual mappings that may be getting
> invalidated.
>
> Use broadcast TLB flushing when that is available.
>
> This is a temporary hack to ensure that the PCID context for
> tasks in the next patch gets properly flushed from the page
> reclaim code, because the IPI based flushing in arch_tlbbatch_flush
> only flushes the currently loaded TLB context on each CPU.
Ok, why am I bothering to review stuff again if you're going to ignore it?
https://lore.kernel.org/r/20250224132711.GHZ7xzr0vdhva3-TvK@fat_crate.local
Please go through all review feedback to v13 and incorporate it properly.
It is not nice to ignore review feedback: you either agree and you incorporate
it or you don't and you explain why.
But ignoring it silently is very unfriendly. :-(
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette