Re: [PATCH v6 04/42] x86/resctrl: Use schema type to determine how to parse schema values

[James Morse]

Hi Reinette,

On 19/02/2025 21:52, Reinette Chatre wrote:
> On 2/7/25 10:17 AM, James Morse wrote:
>> Resctrl's architecture code gets to specify a function pointer that is
>> used when parsing schema entries. This is expected to be one of two
>> helpers from the filesystem code.
>>
>> Setting this function pointer allows the architecture code to change
>> the ABI resctrl presents to user-space, and forces resctrl to expose
>> these helpers.
>>
>> Instead, add a schema format enum to choose which schema parser to
>> use. This allows the helpers to be made static and the structs used
>> for passing arguments moved out of shared headers.

>> diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h
>> index 496ddcaa4ecf..aed231a6d30c 100644
>> --- a/include/linux/resctrl.h
>> +++ b/include/linux/resctrl.h
>> @@ -192,6 +191,16 @@ enum resctrl_scope {
>>  	RESCTRL_L3_NODE,
>>  };
>>  
>> +/**
>> + * enum resctrl_schema_fmt - The format user-space provides for a schema.
>> + * @RESCTRL_SCHEMA_BITMAP:	The schema is a bitmap in hex.
>> + * @RESCTRL_SCHEMA_RANGE:	The schema is a decimal number,
> 
> Nit: Please let sentence end with a period.

... me and my fat fingers ...


>> + */
>> +enum resctrl_schema_fmt {
>> +	RESCTRL_SCHEMA_BITMAP,
>> +	RESCTRL_SCHEMA_RANGE,
>> +};
>> +
>>  /**
>>   * struct rdt_resource - attributes of a resctrl resource
>>   * @rid:		The index of the resource


> | Reviewed-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>

Thanks!

James