Re: [PATCH v6 39/42] x86/resctrl: Split trace.h

[James Morse]

Hi Fenghua, Reinette,

On 25/02/2025 04:36, Fenghua Yu wrote:
> * # Be careful, this email looks suspicious; * Out of Character: The sender is exhibiting
> a significant deviation from their usual behavior, this may indicate that their account
> has been compromised. Be extra cautious before opening links or attachments. *
> Hi, Reinette and James,
> 
> On 2/19/25 21:45, Reinette Chatre wrote:
>> Hi James,
>>
>> On 2/7/25 10:18 AM, James Morse wrote:
>>> trace.h contains all the tracepoints. After the move to /fs/resctrl, some
>>> of these will be left behind. All the pseudo_lock tracepoints remain part
>>> of the architecture. The lone tracepoint in monitor.c moves to /fs/resctrl.
>>>
>>> Split trace.h so that each C file includes a different trace header file.
>>> This means the trace header files are not modified when they are moved.

>> I did not investigate if this originates here or after the code move but
>> when compiling the series (after running the file move script) with W=1

> The issues happen after running the move script.
> 
> It's because no trace event is defined in fs/resctrl/pseudo_lock_trace.h or arch/x86/
> kernel/cpu/resctrl/monitor_trace.h.
> 
> One way to fix them is to add empty events in the trace files. But seems that may cause
> the script difficulty because it cannot handle empty events easily.
> 
> Another way is to remove the two files and their inclusions in .c files. Please see my
> comment and fix in patch #42.

Yup, I have a followup patch that does this:
https://web.git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git/commit/?h=mpam/snapshot/v6.14-rc1&id=3d0430324a0c7e7ad765140f9e78a9a312a13573

I assumed this was harmless, evidently it has some way of upsetting kbuild.

I'll post the version with the followup patches so they can be reviewed and squashed together.


Thanks,

James