Re: [PATCH v6 28/42] x86/resctrl: Handle throttle_mode for SMBA resources

[James Morse]

Hi Reinette,

On 20/02/2025 01:20, Reinette Chatre wrote:
> On 2/7/25 10:18 AM, James Morse wrote:
>> Now that the visibility of throttle_mode is being managed by resctrl, it
>> should consider resources other than MBA that may have a throttle_mode.
>> SMBA is one such resource.
>>
>> Extend resctrl_file_fflags_init() to check SMBA for a throttle_mode.
>>
> 
> "Extend resctrl_file_fflags_init()" -> "Extend thread_throttle_mode_init()"?

Gah, more rebase noise.


>> Adding support for multiple resources means it is possible for a platform
>> with both MBA and SMBA, but an undefined throttle_mode on one of them
>> to make the file visible.
>>
>> Add the 'undefined' case to rdt_thread_throttle_mode_show().

> | Reviewed-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>


Thanks!

James