Re: [PATCH net-next 3/6] net/mlx5e: Enable lanes configuration when auto-negotiation is off

[Jakub Kicinski]

On Wed, 26 Feb 2025 13:47:49 +0200 Tariq Toukan wrote:
> diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
> index 84833cca29fe..49d50afb102c 100644
> --- a/include/uapi/linux/ethtool.h
> +++ b/include/uapi/linux/ethtool.h
> @@ -2192,6 +2192,8 @@ enum ethtool_link_mode_bit_indices {
>  #define SPEED_800000		800000
>  
>  #define SPEED_UNKNOWN		-1
> +#define LANES_UNKNOWN		 0
> +#define MAX_LANES		 8

Almost missed this.

Any reason you're adding to the uAPI header?
Just because that's where SPEED_UNKNOWN is defined?
IIRC lanes are only reported via netlink, so we don't need 
to worry about sharing unspecified values with user space.
Stuff added to the uAPI header is harder to clean up,
if you don't have a strong reason I think we should move 
these defines to the kernel header.
-- 
pw-bot: cr