[PATCH 4/5] io_uring/rsrc: avoid NULL node check on io_sqe_buffer_register() failure
From: Caleb Sander Mateos
Date: Fri Feb 28 2025 - 18:59:37 EST
The done: label is only reachable if node is non-NULL. So don't bother
checking, just call io_free_node().
Signed-off-by: Caleb Sander Mateos <csander@xxxxxxxxxxxxxxx>
---
io_uring/rsrc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/io_uring/rsrc.c b/io_uring/rsrc.c
index 398c6f427bcc..95def9e5f3a7 100644
--- a/io_uring/rsrc.c
+++ b/io_uring/rsrc.c
@@ -835,12 +835,11 @@ static struct io_rsrc_node *io_sqe_buffer_register(struct io_ring_ctx *ctx,
}
done:
if (ret) {
if (imu)
io_free_imu(ctx, imu);
- if (node)
- io_free_node(ctx, node);
+ io_free_node(ctx, node);
node = ERR_PTR(ret);
}
kvfree(pages);
return node;
}
--
2.45.2