Re: [PATCH v2] perf tools: Skip BPF sideband event for userspace profiling

From: Namhyung Kim
Date: Fri Feb 28 2025 - 19:20:47 EST


On Thu, Feb 27, 2025 at 10:50:26AM -0800, Song Liu wrote:
> On Wed, Feb 26, 2025 at 9:17 PM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
> >
> > The BPF sideband information is tracked using a separate thread and
> > evlist. But it's only useful for profiling kernel and we can skip it
> > when users profile their application only in userspace.
> >
> > It seems it already fails to open the sideband event in that case.
> > Let's remove the noise in the verbose output anyway.
> >
> > Cc: Song Liu <song@xxxxxxxxxx>
> > Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>
>
> This turns out to be more complicated than I thought. I actually
> like v1 better.

Sure, the complexity comes from moving the code to reduce the
duplication. But either is fine to me.

Can I add your Acked-by to v1, then?

Thanks,
Namhyung