Re: [PATCH v2] riscv: sophgo: dts: Add spi controller for SG2042

From: Chen Wang
Date: Fri Feb 28 2025 - 20:59:01 EST



On 2025/3/1 2:22, Conor Dooley wrote:
[......]
+
+ spi0: spi@7040004000 {
+ compatible = "snps,dw-apb-ssi";
I thought were were dropping the use of "snps,dw-abp-ssi" in isolation,
and starting to require soc-specific compatibles now.

Rob, Krzysztof?
I'm also very interested to know why we can't just use "snps,dw-abp-ssi", maybe I missed some discussion ...
I googled examples of soc-specific defined in the code, and it doesn't seem to be much, only arch/mips/boot/dts/mscc/ocelot.dtsi and arch/riscv/boot/dts/thead/th1520.dtsi.
Specially, I looked at the commits for th1520 and saw this https://lore.kernel.org/linux-riscv/20240703-garbage-explicit-bd95f8deb716@wendy/. It tells if the fallback works identically, then the specific compatible is not needed.

This makes me more confused :)

Regards,

Chen