Re: [PATCH] fpga: altera-cvp: PCIex8x8 ports

[Xu Yilun]

On Thu, Feb 13, 2025 at 06:35:53AM +0800, Kuhanh Murugasen Krishnan wrote:
First of all, please rewrite your shortlog. It doesn't indicate what
you've done.

> Enabling the possibility of supporting multiple
> PCIe devices from Intel Altera FPGA but with different
> device ids. The current driver registers itself
> to all device IDs which causes an incorrect driver
> association.

Please first state what you've done and what's the problem.

> 
> Signed-off-by: Ang Tien Sung <tien.sung.ang@xxxxxxxxx>
> Signed-off-by: Kuhanh Murugasen Krishnan <kuhanh.murugasen.krishnan@xxxxxxxxx>
> ---
>  drivers/fpga/altera-cvp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/fpga/altera-cvp.c b/drivers/fpga/altera-cvp.c
> index 5af0bd33890c..97e9d4d981ad 100644
> --- a/drivers/fpga/altera-cvp.c
> +++ b/drivers/fpga/altera-cvp.c
> @@ -560,7 +560,7 @@ static int altera_cvp_probe(struct pci_dev *pdev,
>  static void altera_cvp_remove(struct pci_dev *pdev);
>  
>  static struct pci_device_id altera_cvp_id_tbl[] = {
> -	{ PCI_VDEVICE(ALTERA, PCI_ANY_ID) },
> +	{ PCI_VDEVICE(ALTERA, 0x00) },

Does dev_id == 0x00 covers all supported devices? It's a little wield to
me, do you have some DOC?

Thanks,
Yilun

>  	{ }
>  };
>  MODULE_DEVICE_TABLE(pci, altera_cvp_id_tbl);
> -- 
> 2.25.1
> 
>