Re: [PATCH] x86/paravirt: Remove unused paravirt_disable_iospace

[Dr. David Alan Gilbert]

* linux@xxxxxxxxxxx (linux@xxxxxxxxxxx) wrote:
> From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
> 
> The last use of paravirt_disable_iospace() was removed in 2015 by
> commit d1c29465b8a5 ("lguest: don't disable iospace.")
> 
> Remove it.
> 
> Note the comment above it about 'entry.S' is unrelated to this
> but stayed when intervening code got deleted.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>

Oops, missed the .h - v2 coming up.

Dave

> ---
>  arch/x86/kernel/paravirt.c | 20 --------------------
>  1 file changed, 20 deletions(-)
> 
> diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c
> index 1ccaa3397a67..debe92854774 100644
> --- a/arch/x86/kernel/paravirt.c
> +++ b/arch/x86/kernel/paravirt.c
> @@ -90,26 +90,6 @@ void paravirt_set_sched_clock(u64 (*func)(void))
>  	static_call_update(pv_sched_clock, func);
>  }
>  
> -/* These are in entry.S */
> -static struct resource reserve_ioports = {
> -	.start = 0,
> -	.end = IO_SPACE_LIMIT,
> -	.name = "paravirt-ioport",
> -	.flags = IORESOURCE_IO | IORESOURCE_BUSY,
> -};
> -
> -/*
> - * Reserve the whole legacy IO space to prevent any legacy drivers
> - * from wasting time probing for their hardware.  This is a fairly
> - * brute-force approach to disabling all non-virtual drivers.
> - *
> - * Note that this must be called very early to have any effect.
> - */
> -int paravirt_disable_iospace(void)
> -{
> -	return request_resource(&ioport_resource, &reserve_ioports);
> -}
> -
>  #ifdef CONFIG_PARAVIRT_XXL
>  static noinstr void pv_native_write_cr2(unsigned long val)
>  {
> -- 
> 2.48.1
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/