Re: [PATCH] staging: most: Remove unused spinlock from most_video_dev
From: kernel test robot
Date: Sun Mar 02 2025 - 22:19:20 EST
Hi Ravi,
kernel test robot noticed the following build errors:
[auto build test ERROR on staging/staging-testing]
url: https://github.com/intel-lab-lkp/linux/commits/Ravi-Kumar-kairi/staging-most-Remove-unused-spinlock-from-most_video_dev/20250222-004552
base: staging/staging-testing
patch link: https://lore.kernel.org/r/20250221163444.57492-3-kumarkairiravi%40gmail.com
patch subject: [PATCH] staging: most: Remove unused spinlock from most_video_dev
config: hexagon-allyesconfig (https://download.01.org/0day-ci/archive/20250303/202503031028.7ZRlzYcI-lkp@xxxxxxxxx/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250303/202503031028.7ZRlzYcI-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503031028.7ZRlzYcI-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
>> drivers/staging/most/video/video.c:130:23: error: no member named 'list_lock' in 'struct most_video_dev'
130 | spin_lock_irq(&mdev->list_lock);
| ~~~~ ^
drivers/staging/most/video/video.c:134:26: error: no member named 'list_lock' in 'struct most_video_dev'
134 | spin_unlock_irq(&mdev->list_lock);
| ~~~~ ^
drivers/staging/most/video/video.c:136:24: error: no member named 'list_lock' in 'struct most_video_dev'
136 | spin_lock_irq(&mdev->list_lock);
| ~~~~ ^
drivers/staging/most/video/video.c:138:25: error: no member named 'list_lock' in 'struct most_video_dev'
138 | spin_unlock_irq(&mdev->list_lock);
| ~~~~ ^
drivers/staging/most/video/video.c:191:25: error: no member named 'list_lock' in 'struct most_video_dev'
191 | spin_lock_irq(&mdev->list_lock);
| ~~~~ ^
drivers/staging/most/video/video.c:193:27: error: no member named 'list_lock' in 'struct most_video_dev'
193 | spin_unlock_irq(&mdev->list_lock);
| ~~~~ ^
drivers/staging/most/video/video.c:392:27: error: no member named 'list_lock' in 'struct most_video_dev'
392 | spin_lock_irqsave(&mdev->list_lock, flags);
| ~~~~ ^
include/linux/spinlock.h:381:39: note: expanded from macro 'spin_lock_irqsave'
381 | raw_spin_lock_irqsave(spinlock_check(lock), flags); \
| ^~~~
include/linux/spinlock.h:244:34: note: expanded from macro 'raw_spin_lock_irqsave'
244 | flags = _raw_spin_lock_irqsave(lock); \
| ^~~~
drivers/staging/most/video/video.c:394:33: error: no member named 'list_lock' in 'struct most_video_dev'
394 | spin_unlock_irqrestore(&mdev->list_lock, flags);
| ~~~~ ^
drivers/staging/most/video/video.c:399:32: error: no member named 'list_lock' in 'struct most_video_dev'
399 | spin_unlock_irqrestore(&mdev->list_lock, flags);
| ~~~~ ^
drivers/staging/most/video/video.c:477:24: error: no member named 'list_lock' in 'struct most_video_dev'
477 | spin_lock_init(&mdev->list_lock);
| ~~~~ ^
include/linux/spinlock.h:335:38: note: expanded from macro 'spin_lock_init'
335 | __raw_spin_lock_init(spinlock_check(lock), \
| ^~~~
10 errors generated.
vim +130 drivers/staging/most/video/video.c
3d31c0cb6c127b drivers/staging/most/aim-v4l2/video.c Christian Gromm 2015-07-24 114
1b10a0316e2d5e drivers/staging/most/video/video.c Christian Gromm 2017-11-21 115 static int comp_vdev_close(struct file *filp)
3d31c0cb6c127b drivers/staging/most/aim-v4l2/video.c Christian Gromm 2015-07-24 116 {
1b10a0316e2d5e drivers/staging/most/video/video.c Christian Gromm 2017-11-21 117 struct comp_fh *fh = filp->private_data;
3d31c0cb6c127b drivers/staging/most/aim-v4l2/video.c Christian Gromm 2015-07-24 118 struct most_video_dev *mdev = fh->mdev;
3d31c0cb6c127b drivers/staging/most/aim-v4l2/video.c Christian Gromm 2015-07-24 119 struct mbo *mbo, *tmp;
3d31c0cb6c127b drivers/staging/most/aim-v4l2/video.c Christian Gromm 2015-07-24 120
3d31c0cb6c127b drivers/staging/most/aim-v4l2/video.c Christian Gromm 2015-07-24 121 /*
3d31c0cb6c127b drivers/staging/most/aim-v4l2/video.c Christian Gromm 2015-07-24 122 * We need to put MBOs back before we call most_stop_channel()
3d31c0cb6c127b drivers/staging/most/aim-v4l2/video.c Christian Gromm 2015-07-24 123 * to deallocate MBOs.
3d31c0cb6c127b drivers/staging/most/aim-v4l2/video.c Christian Gromm 2015-07-24 124 * From the other hand mostcore still calling rx_completion()
3d31c0cb6c127b drivers/staging/most/aim-v4l2/video.c Christian Gromm 2015-07-24 125 * to deliver MBOs until most_stop_channel() is called.
3d31c0cb6c127b drivers/staging/most/aim-v4l2/video.c Christian Gromm 2015-07-24 126 * Use mute to work around this issue.
3d31c0cb6c127b drivers/staging/most/aim-v4l2/video.c Christian Gromm 2015-07-24 127 * This must be implemented in core.
3d31c0cb6c127b drivers/staging/most/aim-v4l2/video.c Christian Gromm 2015-07-24 128 */
3d31c0cb6c127b drivers/staging/most/aim-v4l2/video.c Christian Gromm 2015-07-24 129
e494df039df0fc drivers/staging/most/aim-v4l2/video.c Christian Gromm 2016-06-06 @130 spin_lock_irq(&mdev->list_lock);
3d31c0cb6c127b drivers/staging/most/aim-v4l2/video.c Christian Gromm 2015-07-24 131 mdev->mute = true;
3d31c0cb6c127b drivers/staging/most/aim-v4l2/video.c Christian Gromm 2015-07-24 132 list_for_each_entry_safe(mbo, tmp, &mdev->pending_mbos, list) {
3d31c0cb6c127b drivers/staging/most/aim-v4l2/video.c Christian Gromm 2015-07-24 133 list_del(&mbo->list);
e494df039df0fc drivers/staging/most/aim-v4l2/video.c Christian Gromm 2016-06-06 134 spin_unlock_irq(&mdev->list_lock);
3d31c0cb6c127b drivers/staging/most/aim-v4l2/video.c Christian Gromm 2015-07-24 135 most_put_mbo(mbo);
e494df039df0fc drivers/staging/most/aim-v4l2/video.c Christian Gromm 2016-06-06 136 spin_lock_irq(&mdev->list_lock);
3d31c0cb6c127b drivers/staging/most/aim-v4l2/video.c Christian Gromm 2015-07-24 137 }
e494df039df0fc drivers/staging/most/aim-v4l2/video.c Christian Gromm 2016-06-06 138 spin_unlock_irq(&mdev->list_lock);
1b10a0316e2d5e drivers/staging/most/video/video.c Christian Gromm 2017-11-21 139 most_stop_channel(mdev->iface, mdev->ch_idx, &comp);
3d31c0cb6c127b drivers/staging/most/aim-v4l2/video.c Christian Gromm 2015-07-24 140 mdev->mute = false;
3d31c0cb6c127b drivers/staging/most/aim-v4l2/video.c Christian Gromm 2015-07-24 141
3d31c0cb6c127b drivers/staging/most/aim-v4l2/video.c Christian Gromm 2015-07-24 142 v4l2_fh_del(&fh->fh);
3d31c0cb6c127b drivers/staging/most/aim-v4l2/video.c Christian Gromm 2015-07-24 143 v4l2_fh_exit(&fh->fh);
3d31c0cb6c127b drivers/staging/most/aim-v4l2/video.c Christian Gromm 2015-07-24 144
3d31c0cb6c127b drivers/staging/most/aim-v4l2/video.c Christian Gromm 2015-07-24 145 atomic_dec(&mdev->access_ref);
3d31c0cb6c127b drivers/staging/most/aim-v4l2/video.c Christian Gromm 2015-07-24 146 kfree(fh);
3d31c0cb6c127b drivers/staging/most/aim-v4l2/video.c Christian Gromm 2015-07-24 147 return 0;
3d31c0cb6c127b drivers/staging/most/aim-v4l2/video.c Christian Gromm 2015-07-24 148 }
3d31c0cb6c127b drivers/staging/most/aim-v4l2/video.c Christian Gromm 2015-07-24 149
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki