RE: drivers/remoteproc/omap_remoteproc.c:732: warning: Function parameter or struct member 'is_iomem' not described in 'omap_rproc_da_to_va'

[Peng Fan]

> Subject: drivers/remoteproc/omap_remoteproc.c:732: warning:
> Function parameter or struct member 'is_iomem' not described in
> 'omap_rproc_da_to_va'

Please drop this warning, Fix has been picked up, see
https://lore.kernel.org/all/Z7yc4vxYkTMhSWni@p14s/

Thanks,
Peng

> 
> Hi Peng,
> 
> FYI, the error/warning still remains.
> 
> tree:
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2F
> git.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2
> Flinux.git&data=05%7C02%7Cpeng.fan%40nxp.com%7C50009dcabea4
> 4860b0c008dd590f683f%7C686ea1d3bc2b4c6fa92cd99c5c301635%7
> C0%7C0%7C638764644912563206%7CUnknown%7CTWFpbGZsb3d8e
> yJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsI
> kFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=qoPgVy
> Jgg36vRNE5HECHYX%2FpAc0T471cj5162D7pc0o%3D&reserved=0
> master
> head:   df87d843c6eb4dad31b7bf63614549dd3521fe71
> commit: 40df0a91b2a5228ded8e5f75b80d28c96c6831cd remoteproc:
> add is_iomem to da_to_va
> date:   4 years ago
> config: arm-randconfig-c041-20230507
> (https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2
> Fdownload.01.org%2F0day-
> ci%2Farchive%2F20250302%2F202503020637.6SBId7IR-
> lkp%40intel.com%2Fconfig&data=05%7C02%7Cpeng.fan%40nxp.com
> %7C50009dcabea44860b0c008dd590f683f%7C686ea1d3bc2b4c6fa92
> cd99c5c301635%7C0%7C0%7C638764644912581628%7CUnknown%
> 7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMC
> IsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C
> %7C&sdata=FEvXgw%2BRm6Io1k9t9QKIdZwSqOgoQDtX9XPZtQLaWO
> M%3D&reserved=0)
> compiler: arm-linux-gnueabi-gcc (GCC) 12.4.0 reproduce (this is a W=1
> build):
> (https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2
> Fdownload.01.org%2F0day-
> ci%2Farchive%2F20250302%2F202503020637.6SBId7IR-
> lkp%40intel.com%2Freproduce&data=05%7C02%7Cpeng.fan%40nxp.c
> om%7C50009dcabea44860b0c008dd590f683f%7C686ea1d3bc2b4c6f
> a92cd99c5c301635%7C0%7C0%7C638764644912593266%7CUnknow
> n%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAw
> MCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%
> 7C%7C&sdata=iDgsV8XXWjRwQftnAuBAzWJFZDAzZyfGcwgXitoHYao%3
> D&reserved=0)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new
> version of the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> | Closes:
> |
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2F
> lore
> | .kernel.org%2Foe-kbuild-all%2F202503020637.6SBId7IR-
> lkp%40intel.com%2F
> |
> &data=05%7C02%7Cpeng.fan%40nxp.com%7C50009dcabea44860b0c
> 008dd590f683f%
> |
> 7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6387646449
> 12604520%7CUnkn
> |
> own%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMD
> AwMCIsIlAiOiJX
> |
> aW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdat
> a=OOJ0eCr4Co
> | iX2DC3nTDyKIKUGLIS8Z7Lbnm140ZB7uk%3D&reserved=0
> 
> All warnings (new ones prefixed by >>):
> 
> >> drivers/remoteproc/omap_remoteproc.c:732: warning: Function
> parameter or struct member 'is_iomem' not described in
> 'omap_rproc_da_to_va'
> 
> 
> vim +732 drivers/remoteproc/omap_remoteproc.c
> 
> 34ed5a33b1218e Ohad Ben-Cohen 2011-10-20  716
> 530a1b57e8590f Suman Anna     2020-03-24  717  /**
> 530a1b57e8590f Suman Anna     2020-03-24  718   *
> omap_rproc_da_to_va() - internal memory translation helper
> 530a1b57e8590f Suman Anna     2020-03-24  719   * @rproc: remote
> processor to apply the address translation for
> 530a1b57e8590f Suman Anna     2020-03-24  720   * @da: device
> address to translate
> 530a1b57e8590f Suman Anna     2020-03-24  721   * @len: length of
> the memory buffer
> 530a1b57e8590f Suman Anna     2020-03-24  722   *
> 530a1b57e8590f Suman Anna     2020-03-24  723   * Custom function
> implementing the rproc .da_to_va ops to provide address
> 530a1b57e8590f Suman Anna     2020-03-24  724   * translation
> (device address to kernel virtual address) for internal RAMs
> 530a1b57e8590f Suman Anna     2020-03-24  725   * present in a DSP
> or IPU device). The translated addresses can be used
> 530a1b57e8590f Suman Anna     2020-03-24  726   * either by the
> remoteproc core for loading, or by any rpmsg bus drivers.
> 530a1b57e8590f Suman Anna     2020-03-24  727   *
> 530a1b57e8590f Suman Anna     2020-03-24  728   * Return:
> translated virtual address in kernel memory space on success,
> 530a1b57e8590f Suman Anna     2020-03-24  729   *         or NULL on
> failure.
> 530a1b57e8590f Suman Anna     2020-03-24  730   */
> 40df0a91b2a522 Peng Fan       2021-03-06  731  static void
> *omap_rproc_da_to_va(struct rproc *rproc, u64 da, size_t len, bool
> *is_iomem)
> 530a1b57e8590f Suman Anna     2020-03-24 @732  {
> 530a1b57e8590f Suman Anna     2020-03-24  733  	struct
> omap_rproc *oproc = rproc->priv;
> 530a1b57e8590f Suman Anna     2020-03-24  734  	int i;
> 530a1b57e8590f Suman Anna     2020-03-24  735  	u32 offset;
> 530a1b57e8590f Suman Anna     2020-03-24  736
> 530a1b57e8590f Suman Anna     2020-03-24  737  	if (len <= 0)
> 530a1b57e8590f Suman Anna     2020-03-24  738
> 	return NULL;
> 530a1b57e8590f Suman Anna     2020-03-24  739
> 530a1b57e8590f Suman Anna     2020-03-24  740  	if (!oproc-
> >num_mems)
> 530a1b57e8590f Suman Anna     2020-03-24  741
> 	return NULL;
> 530a1b57e8590f Suman Anna     2020-03-24  742
> 530a1b57e8590f Suman Anna     2020-03-24  743  	for (i = 0; i <
> oproc->num_mems; i++) {
> 530a1b57e8590f Suman Anna     2020-03-24  744  		if
> (da >= oproc->mem[i].dev_addr && da + len <=
> 530a1b57e8590f Suman Anna     2020-03-24  745
> oproc->mem[i].dev_addr + oproc->mem[i].size) {
> 530a1b57e8590f Suman Anna     2020-03-24  746
> 	offset = da - oproc->mem[i].dev_addr;
> 530a1b57e8590f Suman Anna     2020-03-24  747
> 	/* __force to make sparse happy with type conversion */
> 530a1b57e8590f Suman Anna     2020-03-24  748
> 	return (__force void *)(oproc->mem[i].cpu_addr +
> 530a1b57e8590f Suman Anna     2020-03-24  749
> 				offset);
> 530a1b57e8590f Suman Anna     2020-03-24  750  		}
> 530a1b57e8590f Suman Anna     2020-03-24  751  	}
> 530a1b57e8590f Suman Anna     2020-03-24  752
> 530a1b57e8590f Suman Anna     2020-03-24  753  	return NULL;
> 530a1b57e8590f Suman Anna     2020-03-24  754  }
> 530a1b57e8590f Suman Anna     2020-03-24  755
> 
> :::::: The code at line 732 was first introduced by commit
> :::::: 530a1b57e8590f2ebbb6a35effa0efa988aabf6c remoteproc/omap:
> Add the rproc ops .da_to_va() implementation
> 
> :::::: TO: Suman Anna <s-anna@xxxxxx>
> :::::: CC: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> 
> --
> 0-DAY CI Kernel Test Service
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2F
> github.com%2Fintel%2Flkp-
> tests%2Fwiki&data=05%7C02%7Cpeng.fan%40nxp.com%7C50009dcab
> ea44860b0c008dd590f683f%7C686ea1d3bc2b4c6fa92cd99c5c30163
> 5%7C0%7C0%7C638764644912615595%7CUnknown%7CTWFpbGZsb
> 3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4z
> MiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=htf
> oNpSwSE0sF4eFyya%2FIWJTpP3HrMDmELJYuTCRiVA%3D&reserved=0