Re: [PATCH] kbuild: add dependency from vmlinux to sorttable

From: Masahiro Yamada
Date: Mon Mar 03 2025 - 00:50:13 EST


On Wed, Feb 26, 2025 at 10:30 PM Xi Ruoyao <xry111@xxxxxxxxxxx> wrote:
>
> Without this dependency it's really puzzling when we bisect for a "bad"
> commit in a series of sorttable change: when "git bisect" switches to
> another commit, "make" just does nothing to vmlinux.
>
> Signed-off-by: Xi Ruoyao <xry111@xxxxxxxxxxx>
> ---
> scripts/Makefile.vmlinux | 4 ++++
> 1 file changed, 4 insertions(+)


Applied to linux-kbuild. Thanks.


> diff --git a/scripts/Makefile.vmlinux b/scripts/Makefile.vmlinux
> index 873caaa55313..fb79fd6b2465 100644
> --- a/scripts/Makefile.vmlinux
> +++ b/scripts/Makefile.vmlinux
> @@ -79,6 +79,10 @@ ifdef CONFIG_DEBUG_INFO_BTF
> vmlinux: $(RESOLVE_BTFIDS)
> endif
>
> +ifdef CONFIG_BUILDTIME_TABLE_SORT
> +vmlinux: scripts/sorttable
> +endif
> +
> # module.builtin.ranges
> # ---------------------------------------------------------------------------
> ifdef CONFIG_BUILTIN_MODULE_RANGES
> --
> 2.48.1
>
>


--
Best Regards
Masahiro Yamada