Re: [PATCH v2 12/20] ASoC: mediatek: mt6359-accdet: Always use internal resistor

From: AngeloGioacchino Del Regno
Date: Mon Mar 03 2025 - 06:13:01 EST


Il 02/03/25 17:30, Nícolas F. R. A. Prado ha scritto:
The code currently reads a property mediatek,eint-use-ext-res with
values ranging between 0 and 4. Not only should this be a boolean
property, but there's no need for it to even be a DT property, seeing as
all current boards will use the internal resistor anyway. Since there's
no current dt-binding or Devicetree user of this property, remove its
handling and make the driver always configure the internal resistor.

Signed-off-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx>

Adding up to this - I even checked a few downstream smartphone devicetrees, and
not even those are ever using external resistor. This won't ever be needed.

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>