RE: [PATCH 05/15] gpio: adp5520: use new line value setter callbacks

[Hennerich, Michael]

> -----Original Message-----
> From: Bartosz Golaszewski <brgl@xxxxxxxx>
> Sent: Monday, March 3, 2025 2:19 PM
> To: Linus Walleij <linus.walleij@xxxxxxxxxx>; Bartosz Golaszewski
> <brgl@xxxxxxxx>; Hennerich, Michael <Michael.Hennerich@xxxxxxxxxx>;
> Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>; Mun Yew Tham
> <mun.yew.tham@xxxxxxxxx>; Joel Stanley <joel@xxxxxxxxx>; Andrew Jeffery
> <andrew@xxxxxxxxxxxxxxxxxxxx>
> Cc: linux-gpio@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
> pwm@xxxxxxxxxxxxxxx; patches@xxxxxxxxxxxxxxxxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx; linux-aspeed@xxxxxxxxxxxxxxxx; Bartosz Golaszewski
> <bartosz.golaszewski@xxxxxxxxxx>
> Subject: [PATCH 05/15] gpio: adp5520: use new line value setter callbacks
> 
> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> 
> struct gpio_chip now has callbacks for setting line values that return an
> integer, allowing to indicate failures. Convert the driver to using them.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>

Acked-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx>

> ---
>  drivers/gpio/gpio-adp5520.c | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-adp5520.c b/drivers/gpio/gpio-adp5520.c index
> c55e821c63b6..57d12c10cbda 100644
> --- a/drivers/gpio/gpio-adp5520.c
> +++ b/drivers/gpio/gpio-adp5520.c
> @@ -40,16 +40,18 @@ static int adp5520_gpio_get_value(struct gpio_chip
> *chip, unsigned off)
>  	return !!(reg_val & dev->lut[off]);
>  }
> 
> -static void adp5520_gpio_set_value(struct gpio_chip *chip,
> -		unsigned off, int val)
> +static int adp5520_gpio_set_value(struct gpio_chip *chip,
> +				  unsigned int off, int val)
>  {
>  	struct adp5520_gpio *dev;
>  	dev = gpiochip_get_data(chip);
> 
>  	if (val)
> -		adp5520_set_bits(dev->master, ADP5520_GPIO_OUT, dev-
> >lut[off]);
> +		return adp5520_set_bits(dev->master, ADP5520_GPIO_OUT,
> +					dev->lut[off]);
>  	else
> -		adp5520_clr_bits(dev->master, ADP5520_GPIO_OUT, dev-
> >lut[off]);
> +		return adp5520_clr_bits(dev->master, ADP5520_GPIO_OUT,
> +					dev->lut[off]);
>  }
> 
>  static int adp5520_gpio_direction_input(struct gpio_chip *chip, unsigned off)
> @@ -120,7 +122,7 @@ static int adp5520_gpio_probe(struct platform_device
> *pdev)
>  	gc->direction_input  = adp5520_gpio_direction_input;
>  	gc->direction_output = adp5520_gpio_direction_output;
>  	gc->get = adp5520_gpio_get_value;
> -	gc->set = adp5520_gpio_set_value;
> +	gc->set_rv = adp5520_gpio_set_value;
>  	gc->can_sleep = true;
> 
>  	gc->base = pdata->gpio_start;
> 
> --
> 2.45.2