Re: [PATCH 1/2] net: phy: tja11xx: add support for TJA1102S

[Andrew Lunn]

On Mon, Mar 03, 2025 at 04:14:36PM +0100, Dimitri Fedrau via B4 Relay wrote:
> From: Dimitri Fedrau <dimitri.fedrau@xxxxxxxxxxxx>
> 
> NXPs TJA1102S is a single PHY version of the TJA1102 in which one of the
> PHYs is disabled.
> 
> Signed-off-by: Dimitri Fedrau <dimitri.fedrau@xxxxxxxxxxxx>
> ---
>  drivers/net/phy/nxp-tja11xx.c | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/drivers/net/phy/nxp-tja11xx.c b/drivers/net/phy/nxp-tja11xx.c
> index ed7fa26bac8e83f43d6d656e2e2812e501111eb0..8f3bd27b023b5755c223b6769980aad0b76aad89 100644
> --- a/drivers/net/phy/nxp-tja11xx.c
> +++ b/drivers/net/phy/nxp-tja11xx.c
> @@ -21,6 +21,7 @@
>  #define PHY_ID_TJA1100			0x0180dc40
>  #define PHY_ID_TJA1101			0x0180dd00
>  #define PHY_ID_TJA1102			0x0180dc80
> +#define PHY_ID_TJA1102S			0x0180dc90
>  
>  #define MII_ECTRL			17
>  #define MII_ECTRL_LINK_CONTROL		BIT(15)
> @@ -316,6 +317,8 @@ static int tja11xx_config_init(struct phy_device *phydev)
>  		if (ret)
>  			return ret;
>  		break;
> +	case PHY_ID_TJA1102S:
> +		fallthrough;
>  	case PHY_ID_TJA1101:

You don't need the fallthrough when there are no statements in the
case.


    Andrew

---
pw-bot: cr