Re: [PATCH v2 2/3] selftests: Fix errno checking in syscall_user_dispatch test
From: Gregory Price
Date: Mon Mar 03 2025 - 11:12:33 EST
On Mon, Feb 24, 2025 at 09:45:26AM +0100, Dmitry Vyukov wrote:
> /* len != 0 */
> - prctl(PR_SET_SYSCALL_USER_DISPATCH, op, 0x0, 0xff, 0);
> + EXPECT_EQ(-1, prctl(PR_SET_SYSCALL_USER_DISPATCH, op, 0x0, 0xff, 0));
> EXPECT_EQ(EINVAL, errno);
This patch should probably just be pulled ahead of everything else,
since you change the behavior of the syscall, and now you're updating
the test - but it will fail (since this no longer produces EINVAL).
This patch should probably just be entirely separate, maybe even in
stable?
~Gregory