Re: [PATCH] perf build: fix in-tree build
From: Namhyung Kim
Date: Mon Mar 03 2025 - 12:22:34 EST
On Fri, Jan 24, 2025 at 02:06:08PM +0100, Luca Ceresoli wrote:
> Building perf in-tree is broken after commit 890a1961c812 ("perf tools:
> Create source symlink in perf object dir") which added a 'source' symlink
> in the output dir pointing to the source dir.
>
> With in-tree builds, the added 'SOURCE = ...' line is executed multiple
> times (I observed 2 during the build plus 2 during installation). This is a
> minor inefficiency, in theory not harmful because symlink creation is
> assumed to be idempotent. But it is not.
>
> Considering with in-tree builds:
>
> srctree=/absolute/path/to/linux
> OUTPUT=/absolute/path/to/linux/tools/perf
>
[...]
Applied to perf-tools-next, thanks!
Best Regards,
Namhyung