Re: [PATCH v2 1/4] dt-bindings: i3c: silvaco: Add npcm845 compatible string

[Conor Dooley]

On Thu, Feb 20, 2025 at 01:43:27PM +0800, Stanley Chu wrote:
> Add a compatible string for Nuvoton BMC NPCM845 i3c controller.

Why is a fallback not an option here? Your commit message should call
out why not.

> 
> Signed-off-by: Stanley Chu <yschu@xxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
> index c56ff77677f1..9be4bc4cc482 100644
> --- a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
> +++ b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
> @@ -14,7 +14,9 @@ allOf:
>  
>  properties:
>    compatible:
> -    const: silvaco,i3c-master-v1
> +    enum:
> +      - silvaco,i3c-master-v1
> +      - nuvoton,npcm845-i3c
>  
>    reg:
>      maxItems: 1
> -- 
> 2.34.1
> 
>

Attachment: signature.asc
Description: PGP signature