Re: Unwired pvrdma_modify_device ?

From: Dr. David Alan Gilbert
Date: Mon Mar 03 2025 - 13:42:34 EST


* Jason Gunthorpe (jgg@xxxxxxxx) wrote:
> On Sun, Mar 02, 2025 at 10:05:11PM +0000, Dr. David Alan Gilbert wrote:
> > Hi,
> > I noticed that pvrdma_modify_device() in
> > drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c
> > isn't called anywhere; shouldn't it be wired up in pvrdma_dev_ops ?
> >
> > (I've not got VMWare anywhere to try it on, and don't know the innards
> > of RDMA drivers; so can't really test it).

Hi Jason,
Thanks for the reply,

> Seems probably right
>
> But at this point I'd just delete it unless pvrdma maintainers say
> otherwise in the next week

OK, lets see if they wake up.

Dave

> Jason
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/