Re: [PATCH net-next 3/6] net/mlx5e: Enable lanes configuration when auto-negotiation is off

[Jakub Kicinski]

On Sun, 2 Mar 2025 10:17:58 +0200 Shahar Shitrit wrote:
> On 01/03/2025 0:51, Jakub Kicinski wrote:
> > On Wed, 26 Feb 2025 13:47:49 +0200 Tariq Toukan wrote:  
> >> +		if (table[i].speed == info->speed) {
> >> +			if (!info->lanes || table[i].lanes == info->lanes)  
> > 
> > Hm, on a quick look it seems like lane count was added in all tables,
> > so not sure why the !info->lanes
> >  
> it's for the case only speed was passed from ethtool (then ethtool
> passes 0 for lanes)

Makes sense, I think I read the condition backwards TBH 
(table[i] vs info).