Re: [PATCH 7/7] mm/mremap: thread state through move page table operation

[Andrew Morton]

On Mon, 3 Mar 2025 16:05:55 -0800 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> --- a/mm/mremap.c~mm-mremap-thread-state-through-move-page-table-operation-fix
> +++ a/mm/mremap.c
> @@ -475,8 +475,9 @@ static bool move_huge_pud(struct pagetab
>  	return true;
>  }
>  #else
> -static bool move_huge_pud(struct vm_area_struct *vma, unsigned long old_addr,
> -			  unsigned long new_addr, pud_t *old_pud, pud_t *new_pud)
> +static bool move_huge_pud(struct pagetable_move_control *pmc,
> +			  unsigned long old_addr, unsigned long new_addr,
> +			  pud_t *old_pud, pud_t *new_pud)
>  {
>  	WARN_ON_ONCE(1);
>  	return false;

err,

--- a/mm/mremap.c~mm-mremap-thread-state-through-move-page-table-operation-fix
+++ a/mm/mremap.c
@@ -475,8 +475,8 @@ static bool move_huge_pud(struct pagetab
 	return true;
 }
 #else
-static bool move_huge_pud(struct vm_area_struct *vma, unsigned long old_addr,
-			  unsigned long new_addr, pud_t *old_pud, pud_t *new_pud)
+static bool move_huge_pud(struct pagetable_move_control *pmc,
+			  pud_t *old_pud, pud_t *new_pud)
 {
 	WARN_ON_ONCE(1);
 	return false;
_