Re: [PATCH V9 2/7] interconnect: core: Add dynamic id allocation support

[Raviteja Laggyshetty]

On 2/27/2025 9:38 PM, Dmitry Baryshkov wrote:
> On Thu, Feb 27, 2025 at 03:52:08PM +0000, Raviteja Laggyshetty wrote:
>> The current interconnect framework relies on static IDs for node
>> creation and registration, which limits topologies with multiple
>> instances of the same interconnect provider. To address this, update
>> the interconnect framework APIs icc_node_create() and icc_link_create()
>> APIs to dynamically allocate IDs for interconnect nodes during creation.
>> This change removes the dependency on static IDs, allowing multiple
>> instances of the same hardware, such as EPSS L3.
>>
>> Signed-off-by: Raviteja Laggyshetty <quic_rlaggysh@xxxxxxxxxxx>
>> ---
>>  drivers/interconnect/core.c  | 13 ++++++++++++-
>>  include/linux/interconnect.h |  3 +++
>>  2 files changed, 15 insertions(+), 1 deletion(-)
>>
> 
> 
> 
>> diff --git a/include/linux/interconnect.h b/include/linux/interconnect.h
>> index 97ac253df62c..8b0f892aaed2 100644
>> --- a/include/linux/interconnect.h
>> +++ b/include/linux/interconnect.h
>> @@ -20,6 +20,9 @@
>>  #define Mbps_to_icc(x)	((x) * 1000 / 8)
>>  #define Gbps_to_icc(x)	((x) * 1000 * 1000 / 8)
>>  
>> +/* macro to indicate dynamic id allocation */
>> +#define ALLOC_DYN_ID	-1
> 
> Nit: ICC_ALLOC_DYN_ID
> 
> With that fixed,
> 
Will fix it in next revision.

> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> 
>> +
>>  struct icc_path;
>>  struct device;
>>  
>> -- 
>> 2.43.0
>>
>