Re: [PATCH v2 03/12] iommu: Remove IOMMU_DEV_FEAT_SVA

[Yi Liu]

On 2025/2/24 13:16, Lu Baolu wrote:
> From: Jason Gunthorpe <jgg@xxxxxxxxxx>
>
> None of the drivers implement anything here anymore, remove the dead code.
>
> Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx>
> Signed-off-by: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
> ---
>   drivers/accel/amdxdna/aie2_pci.c            | 13 ++-----------
>   drivers/dma/idxd/init.c                     |  8 +-------
>   drivers/iommu/amd/iommu.c                   |  2 --
>   drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c |  2 --
>   drivers/iommu/intel/iommu.c                 |  6 ------
>   drivers/iommu/iommu-sva.c                   |  3 ---
>   drivers/misc/uacce/uacce.c                  |  9 ---------
>   include/linux/iommu.h                       |  9 +--------
>   8 files changed, 4 insertions(+), 48 deletions(-)

Reviewed-by: Yi Liu <yi.l.liu@xxxxxxxxx>

with a nit:


> diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c
> index b946f78f85e1..1e5038cca22c 100644
> --- a/drivers/dma/idxd/init.c
> +++ b/drivers/dma/idxd/init.c
> @@ -633,17 +633,11 @@ static int idxd_enable_sva(struct pci_dev *pdev)
>   	ret = iommu_dev_enable_feature(&pdev->dev, IOMMU_DEV_FEAT_IOPF);
>   	if (ret)

delete this check, and return ret.

>   		return ret;
> -
> -	ret = iommu_dev_enable_feature(&pdev->dev, IOMMU_DEV_FEAT_SVA);
> -	if (ret)
> -		iommu_dev_disable_feature(&pdev->dev, IOMMU_DEV_FEAT_IOPF);
> -
> -	return ret;
> +	return 0;

--
Regards,
Yi Liu