Re: [PATCH v3 05/15] dt-bindings: clk: sunxi-ng: add compatible for the A523 PRCM-CCU

From: Krzysztof Kozlowski
Date: Tue Mar 04 2025 - 03:25:03 EST


On Tue, Mar 04, 2025 at 01:27:55AM +0000, Andre Przywara wrote:
> The Allwinner A523/T527 SoCs have four CCUs, this adds the binding for
> the PRCM R_CCU.
>
> Add the new compatible string, along with the required input clock
> lists. There is now an extra input clock (PLL_AUDIO), so add this to the
> list of allowed clocks and required it for the A523 PRCM CCU.
> Also add the DT binding headers, listing all the clocks with their ID
> numbers.
>
> Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>
> ---
> .../clock/allwinner,sun55i-a523-ccu.yaml | 23 +++++++++++-
> include/dt-bindings/clock/sun55i-a523-r-ccu.h | 37 +++++++++++++++++++
> include/dt-bindings/reset/sun55i-a523-r-ccu.h | 25 +++++++++++++
> 3 files changed, 83 insertions(+), 2 deletions(-)
> create mode 100644 include/dt-bindings/clock/sun55i-a523-r-ccu.h
> create mode 100644 include/dt-bindings/reset/sun55i-a523-r-ccu.h
>
> diff --git a/Documentation/devicetree/bindings/clock/allwinner,sun55i-a523-ccu.yaml b/Documentation/devicetree/bindings/clock/allwinner,sun55i-a523-ccu.yaml
> index 2eacaeaeabac7..a64a35b423736 100644
> --- a/Documentation/devicetree/bindings/clock/allwinner,sun55i-a523-ccu.yaml
> +++ b/Documentation/devicetree/bindings/clock/allwinner,sun55i-a523-ccu.yaml
> @@ -19,17 +19,18 @@ properties:
> compatible:
> enum:
> - allwinner,sun55i-a523-ccu
> + - allwinner,sun55i-a523-r-ccu
>
> reg:
> maxItems: 1
>
> clocks:
> minItems: 4
> - maxItems: 4
> + maxItems: 5

You just added these lines in previous patch, so squash these and make a
complete binding in one patch.

Otherwise you will get comment like:

>
> clock-names:
> minItems: 4

This is not supposed to be here in previous patch...

> - maxItems: 4
> + maxItems: 5

Best regards,
Krzysztof