Re: [PATCH v2 19/24] perf: Simplify perf_mmap() control flow
From: Ingo Molnar
Date: Tue Mar 04 2025 - 03:44:14 EST
* Ravi Bangoria <ravi.bangoria@xxxxxxx> wrote:
> Hi Ingo,
>
> >>> -
> >>> /* We need the rb to map pages. */
> >>
> >> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> >> This comment should also go up. Keeping it here is misleading.
> >
> > Yeah, I did that in the conflict resolution (which conflicted in this
> > very area), so the end result in tip:perf/core (or tip:master) should
> > be fine as-is, correct?
>
> Yes, tip:perf/core looks good.
Great, thank you for checking!
I also picked up:
bfd33e88addd perf/core: Fix perf_mmap() failure path
and have added your Reviewed-by tags to the series.
Thanks,
Ingo