RE: [Intel-wired-lan] [PATCH v2] e1000: The 'const' qualifier has been added where applicable to enhance code safety and prevent unintended modifications.
From: Loktionov, Aleksandr
Date: Tue Mar 04 2025 - 04:13:49 EST
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of
> joaomboni
> Sent: Monday, March 3, 2025 9:48 PM
> To: Nguyen, Anthony L <anthony.l.nguyen@xxxxxxxxx>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@xxxxxxxxx>; andrew+netdev@xxxxxxx;
> davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx;
> pabeni@xxxxxxxxxx
> Cc: intel-wired-lan@xxxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; joaomboni <joaoboni017@xxxxxxxxx>
> Subject: [Intel-wired-lan] [PATCH v2] e1000: The 'const' qualifier has been
> added where applicable to enhance code safety and prevent unintended
> modifications.
>
> Signed-off-by: Joao Bonifacio <joaoboni017@xxxxxxxxx>
Good!
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@xxxxxxxxx>
> ---
> drivers/net/ethernet/intel/e1000/e1000_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c
> b/drivers/net/ethernet/intel/e1000/e1000_main.c
> index 3f089c3d47b2..96bc85f09aaf 100644
> --- a/drivers/net/ethernet/intel/e1000/e1000_main.c
> +++ b/drivers/net/ethernet/intel/e1000/e1000_main.c
> @@ -9,7 +9,7 @@
> #include <linux/if_vlan.h>
>
> char e1000_driver_name[] = "e1000";
> -static char e1000_driver_string[] = "Intel(R) PRO/1000 Network Driver";
> +static const char e1000_driver_string[] = "Intel(R) PRO/1000 Network
> Driver";
> static const char e1000_copyright[] = "Copyright (c) 1999-2006 Intel
> Corporation.";
>
> /* e1000_pci_tbl - PCI Device ID Table
> --
> 2.48.1