Re: [PATCH 08/11] arm64: dts: qcom: sa8775p-ride: enable Display serial interface

[Ayushi Makhija]

On 2/25/2025 11:25 PM, Dmitry Baryshkov wrote:
> On Tue, Feb 25, 2025 at 05:48:21PM +0530, Ayushi Makhija wrote:
>> Enable both DSI to DP bridge ports on SA8775P Ride plaftrom.
>>
>> Signed-off-by: Ayushi Makhija <quic_amakhija@xxxxxxxxxxx>
>> ---
>>  arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 66 +++++++++++++++++++++-
>>  1 file changed, 64 insertions(+), 2 deletions(-)
> 
> Please squash into the previous patch. It doesn't make a lot of sense separately.
> 
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
>> index 151f66512303..02d8a9c2c909 100644
>> --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
>> @@ -128,6 +128,30 @@ dp1_connector_in: endpoint {
>>  			};
>>  		};
>>  	};
>> +
>> +	dsi0-connector {
> 
> dpN-connector. It is not DSI.

Hi Dmitry, Konrad

Thanks, for the review.

I will change dsi0-connector -> dp2-connector and dsi1-connector -> dp3-connector respectively.

> 
>> +		compatible = "dp-connector";
>> +		label = "DSI0";
> 
> Is it an actual label on it?

The label for DSI to DP bridge ports itself on the device is DSI0 and DSI1 respectively.

Thanks,
Ayushi