Re: [PATCH 07/11] arm64: dts: qcom: sa8775p-ride: add anx7625 DSI to DP bridge nodes

From: Ayushi Makhija
Date: Tue Mar 04 2025 - 04:59:07 EST


On 2/26/2025 2:05 PM, Krzysztof Kozlowski wrote:
> On Tue, Feb 25, 2025 at 02:31:05PM +0100, Krzysztof Kozlowski wrote:
>> On 25/02/2025 13:18, Ayushi Makhija wrote:
>>> + pinctrl-0 = <&dsi0_int_pin>,
>>> + <&dsi0_cbl_det_pin>,
>>> + <&dsi1_int_pin>,
>>> + <&dsi1_cbl_det_pin>;
>>> + pinctrl-names = "default";
>>> +
>>> + dsi0_int_pin: gpio2_cfg {
>>
>>
>> No underscores, see DTS coding style.
>
> And as Rob's bot pointed out: insufficient testing. :(
>
> Please be 100% sure everything is tested before you post new version.
> You shouldn't use reviewers for the job of tools, that's quite waste of
> our time.
>
> Best regards,
> Krzysztof

Hi Krzysztof,

Thanks, for the review.

Sorry for the mistake. I will post the clean patch in my next patchset.

Thank,
Ayushi