Re: [PATCH v8 3/7] rust: str: implement `AsRef<BStr>` for `[u8]` and `BStr`
From: Fiona Behrens
Date: Tue Mar 04 2025 - 06:10:35 EST
Andreas Hindborg <a.hindborg@xxxxxxxxxx> writes:
> Implement `AsRef<BStr>` for `[u8]` and `BStr` so these can be used
> interchangeably for operations on `BStr`.
>
> Reviewed-by: Gary Guo <gary@xxxxxxxxxxx>
> Tested-by: Daniel Almeida <daniel.almeida@xxxxxxxxxxxxx>
> Reviewed-by: Daniel Almeida <daniel.almeida@xxxxxxxxxxxxx>
> Signed-off-by: Andreas Hindborg <a.hindborg@xxxxxxxxxx>
Reviewed-by: Fiona Behrens <me@xxxxxxxxxx>
> ---
> rust/kernel/str.rs | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/rust/kernel/str.rs b/rust/kernel/str.rs
> index ba6b1a5c4f99..c6bd2c69543d 100644
> --- a/rust/kernel/str.rs
> +++ b/rust/kernel/str.rs
> @@ -125,6 +125,18 @@ fn index(&self, index: Idx) -> &Self::Output {
> }
> }
>
> +impl AsRef<BStr> for [u8] {
> + fn as_ref(&self) -> &BStr {
> + BStr::from_bytes(self)
> + }
> +}
> +
> +impl AsRef<BStr> for BStr {
> + fn as_ref(&self) -> &BStr {
> + self
> + }
> +}
> +
> /// Creates a new [`BStr`] from a string literal.
> ///
> /// `b_str!` converts the supplied string literal to byte string, so non-ASCII