Re: [PATCH v5 03/10] iio: adc: add helpers for parsing ADC nodes
From: Andy Shevchenko
Date: Tue Mar 04 2025 - 07:08:10 EST
On Tue, Mar 04, 2025 at 10:25:03AM +0100, David Lechner wrote:
> On Mon, Mar 3, 2025 at 12:32 PM Matti Vaittinen
> <mazziesaccount@xxxxxxxxx> wrote:
...
> There are some different opinions on this, but on the last patch I did
> introducing a new namespace,
> the consensus
Hmm... I may not call that "the consensus"...
> seems to be that putting
> the MODULE_IMPORT_NS() in the header file was convenient so that users
> of the API don't have to remember to both include the header and add
> the import macro.
Which I am against because it will diminish the point of prevention of
the APIs abuse along with a potential to have the stale headers in
the file when the code is moved somewhere else..
So, please do not do that. We have only two abusers currently:
the PWM and SPI OFFLOAD.
--
With Best Regards,
Andy Shevchenko