Re:[PATCH V2] usb: xhci: Add debugfs support for xHCI port bandwidth
From: raoxu
Date: Tue Mar 04 2025 - 07:52:18 EST
On 2025/3/4 20:31, Mathias Nyman wrote:
>I do however have some larger rework suggestions to this.
>
>Instead of queuing three commands on one file read, parsing and
>copy the content from each context dma into an array on stack, we could
>have separate files in debugfs for each speed, and queue one command
>for each. we could also skip the array on stack and print values from context
>directly.
>
>Something is also very off with the locks in this patch.
>Looks like every lock/unlock got replaced with an unlock
thanks Mathias Nyman,
Thank you for your valuable suggestions.I will separate files in debugfs for each speed.
skipping the array on stack and print values from context directly sounds good. looks is a error and i will fix it.
According to your suggestion i will send patch v3
thanks,
raoxu