Re: [PATCH v2 5/5] ASoC: wm8904: add DMIC support

[Charles Keepax]

On Mon, Feb 24, 2025 at 04:55:00PM +0100, Francesco Dolcini wrote:
> From: Ernest Van Hoecke <ernest.vanhoecke@xxxxxxxxxxx>
> 
> The WM8904 codec supports both ADC and DMIC inputs.
> 
> Get input pin functionality from the platform data and add the necessary
> controls depending on the possible additional routing.
> 
> The ADC and DMIC share the IN1L/DMICDAT1 and IN1R/DMICDAT2 pins.
> 
> This leads to a few scenarios requiring different DAPM routing:
> - When both are connected to an analog input, only the ADC is used.
> - When one line is a DMIC and the other an analog input, the DMIC source
>   is set from the platform data and a mux is added to select whether to
>   use the ADC or DMIC.
> - When both are connected to a DMIC, another mux is added to this to
>   select the DMIC source. Note that we still need to be able to select
>   the ADC system for use with the IN2L, IN2R, IN3L and IN3R pins.
> 
> Signed-off-by: Ernest Van Hoecke <ernest.vanhoecke@xxxxxxxxxxx>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx>
> ---

Apologies for the delay, I think this looks good to me:

Reviewed-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>

Thanks,
Charles