Re: [PATCH 1/8] media: dt-bindings: Document SC8280XP/SM8350 Venus

[Krzysztof Kozlowski]

On 04/03/2025 14:07, Bryan O'Donoghue wrote:
> From: Konrad Dybcio <konradybcio@xxxxxxxxxx>
> 
> Both of these SoCs implement an IRIS2 block, with SC8280XP being able
> to clock it a bit higher.
> 
> Document it.
> 
> Signed-off-by: Konrad Dybcio <konradybcio@xxxxxxxxxx>
> Link: https://lore.kernel.org/r/20230731-topic-8280_venus-v1-1-8c8bbe1983a5@xxxxxxxxxx
> Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
> [ bod: dropped dts video-encoder/video-decoder ]
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> ---


If this is the same version, then please implement previous feedback.

If this is a new version, then please mark it as v2 and provide
changelog. This is what b4 gave me:

b4 diff
'<20250304-b4-linux-media-comitters-sc8280xp-venus-v1-1-279c7ea55493@xxxxxxxxxx>'
Grabbing thread from
lore.kernel.org/all/20250304-b4-linux-media-comitters-sc8280xp-venus-v1-1-279c7ea55493@xxxxxxxxxx/t.mbox.gz
Breaking thread to remove parents of
20250304-b4-linux-media-comitters-sc8280xp-venus-v1-0-279c7ea55493@xxxxxxxxxx
---
Analyzing 9 messages in the thread
Could not find lower series to compare against.

...

> +
> +        operating-points-v2 = <&venus_opp_table>;
> +        iommus = <&apps_smmu 0x2100 0x400>;
> +        memory-region = <&pil_video_mem>;
> +
> +        status = "disabled";

So it is the same...

Same comments apply, same review.

Best regards,
Krzysztof