Re: [PATCH next] iio: adc: ad4030: fix error pointer dereference in probe()

From: Jonathan Cameron
Date: Tue Mar 04 2025 - 10:00:54 EST


On Fri, 28 Feb 2025 13:22:37 +0000
Nuno Sá <noname.nuno@xxxxxxxxx> wrote:

> On Fri, 2025-02-28 at 12:35 +0300, Dan Carpenter wrote:
> > The intention here was obviously to return an error if devm_regmap_init()
> > fails, but the return statement was accidentally left out.  This leads to
> > an error pointer dereference when we call:
> >
> > ret = ad4030_detect_chip_info(st);
> >
> > Add the return statement.
> >
> > Fixes: ec25cf6f1ee3 ("iio: adc: ad4030: add support for ad4632-16 and ad4632-
> > 24")
> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> > ---
>
> Reviewed-by: Nuno Sá <nuno.sa@xxxxxxxxxx>
Applied.