Re: [PATCH] drm/appletbdrm: Fix format specifier for size_t variables

[Jani Nikula]

On Tue, 04 Mar 2025, Aditya Garg <gargaditya08@xxxxxxxx> wrote:
>> On 4 Mar 2025, at 6:49 PM, Nathan Chancellor <nathan@xxxxxxxxxx> wrote:
>> 
>> When building for a 32-bit platform, there are some warnings (or errors
>> with CONFIG_WERROR=y) due to an incorrect specifier for 'size_t'
>> variables, which is typedef'd as 'unsigned int' for these architectures:
>> 
>>  drivers/gpu/drm/tiny/appletbdrm.c:171:17: error: format specifies type 'unsigned long' but the argument has type 'size_t' (aka 'unsigned int') [-Werror,-Wformat]
>>    170 |                 drm_err(drm, "Actual size (%d) doesn't match expected size (%lu)\n",
>>        |                                                                             ~~~
>>        |                                                                             %zu
>>    171 |                         actual_size, size);
>>        |                                      ^~~~
>>  ...
>>  drivers/gpu/drm/tiny/appletbdrm.c:212:17: error: format specifies type 'unsigned long' but the argument has type 'size_t' (aka 'unsigned int') [-Werror,-Wformat]
>>    211 |                 drm_err(drm, "Actual size (%d) doesn't match expected size (%lu)\n",
>>        |                                                                             ~~~
>>        |                                                                             %zu
>>    212 |                         actual_size, size);
>>        |                                      ^~~~
>> 
>> Use '%zu' as suggested, clearing up the warnings.
>> 
>> Fixes: 0670c2f56e45 ("drm/tiny: add driver for Apple Touch Bars in x86 Macs")
>> Signed-off-by: Nathan Chancellor <nathan@xxxxxxxxxx>
>> ---
>> drivers/gpu/drm/tiny/appletbdrm.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> This went into my spam for some reason, but looks like Jani already informed you about my Ack :)

Thanks for the patch and ack, pushed to drm-misc-next.

BR,
Jani.



-- 
Jani Nikula, Intel